I keep all the old flares. While most people carry aerial flares, their use is really best for offshore, where the bulk of those on this site are not going to be. If you have seen aerial flares shot off, their only advantage is that they can be seen from far away. I'm a big believer in smoke, at least for daytime use. Smoke is VERY noticable and from surprising distances. Best to carry a mix. If you already have handheld flares, buy smoke. If you have smoke, but aerial or handheld. Keep everything. Rotate what you renew. If you have nothing, aerial would be the last one I would buy. Most of your boating should be daytime, so get what works best in the daytime.
None of them last for very long when you use them.
Shooting them off to test them, is a good way to get a trip to the pokey.